[INTF25] Build filter for fetch review dashboard query#83
Open
[INTF25] Build filter for fetch review dashboard query#83
Conversation
ruiichen
force-pushed
the
INTF25-review-dashboard-query-filter
branch
from
7ddb85e to
b4f17ba
Compare
4 tasks
ruiichen
force-pushed
the
INTF25-review-dashboard-query-filter
branch
from
ce4d304 to
1b0f5a7
Compare
added 6 commits
November 29, 2025 13:41
# Conflicts: # backend/typescript/graphql/resolvers/reviewDashboardResolvers.ts # backend/typescript/graphql/types/reviewDashboardType.ts # backend/typescript/services/implementations/reviewDashboardService.ts # backend/typescript/services/interfaces/IReviewDashboardService.ts
ruiichen
force-pushed
the
INTF25-review-dashboard-query-filter
branch
from
9b0c437 to
80878d6
Compare
mxc-maggiechen
requested changes
Nov 29, 2025
Comment on lines
53
to
93
| if (filter.role) { | ||
| if (filter.role.toString() === "int_dir") { | ||
| exp.push({ position: { [Op.eq]: "Internal Director" } }); | ||
| } else if (filter.role.toString() === "ext_dir") { | ||
| exp.push({ position: { [Op.eq]: "External Director" } }); | ||
| } else if (filter.role.toString() === "pres") { | ||
| exp.push({ position: { [Op.eq]: "President" } }); | ||
| } else if (filter.role.toString() === "vpe") { | ||
| exp.push({ position: { [Op.eq]: "VP Engineering" } }); | ||
| } else if (filter.role.toString() === "vpd") { | ||
| exp.push({ position: { [Op.eq]: "VP Design" } }); | ||
| } else if (filter.role.toString() === "vpp") { | ||
| exp.push({ position: { [Op.eq]: "VP Product" } }); | ||
| } else if (filter.role.toString() === "vpt") { | ||
| exp.push({ position: { [Op.eq]: "VP Talent" } }); | ||
| } else if (filter.role.toString() === "vp_ext") { | ||
| exp.push({ position: { [Op.eq]: "VP External" } }); | ||
| } else if (filter.role.toString() === "vp_int") { | ||
| exp.push({ position: { [Op.eq]: "VP Internal" } }); | ||
| } else if (filter.role.toString() === "vp_comms") { | ||
| exp.push({ position: { [Op.eq]: "VP Community" } }); | ||
| } else if (filter.role.toString() === "vp_scoping") { | ||
| exp.push({ position: { [Op.eq]: "VP Scoping" } }); | ||
| } else if (filter.role.toString() === "vp_finance") { | ||
| exp.push({ position: { [Op.eq]: "VP Finance" } }); | ||
| } else if (filter.role.toString() === "pm") { | ||
| exp.push({ position: { [Op.eq]: "Project Manager" } }); | ||
| } else if (filter.role.toString() === "pl") { | ||
| exp.push({ position: { [Op.eq]: "Project Lead" } }); | ||
| } else if (filter.role.toString() === "design_mentor") { | ||
| exp.push({ position: { [Op.eq]: "Design Mentor" } }); | ||
| } else if (filter.role.toString() === "graphic_design") { | ||
| exp.push({ position: { [Op.eq]: "Graphic Design" } }); | ||
| } else if (filter.role.toString() === "product_design") { | ||
| exp.push({ position: { [Op.eq]: "Product Design" } }); | ||
| } else if (filter.role.toString() === "uxr") { | ||
| exp.push({ position: { [Op.eq]: "User Researcher" } }); | ||
| } else if (filter.role.toString() === "dev") { | ||
| exp.push({ position: { [Op.eq]: "Developer" } }); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
how do you feel if we just pass in a position string instead of making GraphQL guard with an enum. if we can't find anything entries with matching position string, we just return empty array. just looking at this term, we added i think 2 new positions, i think doing it without this enum check would make it easier to add new positions.
Contributor
There was a problem hiding this comment.
do you think we can also do multi-select positions for filtering? i think i see that in the design right now, so it would be good to have that option if it's not too bad to implement 🙏
ericahan22
reviewed
Dec 4, 2025
Member
ericahan22
left a comment
ericahan22
left a comment
There was a problem hiding this comment.
Looks good to me! But maybe remove the .idea files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notion ticket link
Ticket Name
Implementation description
Steps to test
applicantsandapplicant_records, and filter for that record in the GraphQL query. Below is the query template.What should reviewers focus on?
Checklist